Skip to content

pathchk: build for Windows#11495

Open
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:pathchk-w
Open

pathchk: build for Windows#11495
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:pathchk-w

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented Mar 25, 2026

No description provided.

@oech3 oech3 force-pushed the pathchk-w branch 2 times, most recently from e451c7a to 91c9943 Compare March 25, 2026 21:07
sylvestre
sylvestre reviewed Mar 25, 2026
View reviewed changes
sylvestre
sylvestre reviewed Mar 25, 2026
View reviewed changes
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 25, 2026 •
edited
Loading

Merging this PR will improve performance by 4.84%

⚡ 1 improved benchmark
✅ 299 untouched benchmarks
⏩ 46 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Simulation sort_ascii_utf8_locale 16.1 ms 15.4 ms +4.84%

Comparing oech3:pathchk-w (4a71d77) with main (af6c8f2)2

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (2b05f2f) during the generation of this report, so af6c8f2 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 25, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/misc/io-errors is no longer failing!
Note: The gnu test tests/rm/many-dir-entries-vs-OOM is now being skipped but was previously passing.
Note: The gnu test tests/tail/pipe-f is now being skipped but was previously passing.

oech3
oech3 commented Mar 25, 2026
View reviewed changes
@oech3 oech3 marked this pull request as ready for review March 25, 2026 21:50
@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Mar 25, 2026

Ready.

@oech3 oech3 requested a review from sylvestre March 25, 2026 22:12
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 26, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/date/resolution (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/cp/link-heap is now passing!
Note: The gnu test tests/misc/write-errors was skipped on 'main' but is now failing.

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Mar 27, 2026

I should remove pathchk from unix progs.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/tail/pipe-f is now passing!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/cut/cut-huge-range is now being skipped but was previously passing.
Congrats! The gnu test tests/tail/pipe-f is now passing!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/basenc/bounded-memory is now being skipped but was previously passing.
Congrats! The gnu test tests/tail/pipe-f is now passing!

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented Mar 27, 2026 •
edited
Loading

I don't know how does it work, but cargo check passed on RedoxOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylvestre sylvestre Awaiting requested review from sylvestre

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oech3 @sylvestre